test: another echo_integration_test fix#4350
Merged
dnoe merged 2 commits intoenvoyproxy:masterfrom Sep 6, 2018
Merged
Conversation
OS X's localhost interface often takes longer to fail to connect then Linux. Modifies RawConnectionDriver to detect when its underlying connection is connected or failed and pauses the echo_integration_test until that state is reached before checking the connection state. *Risk Level*: low, test-only changes *Testing*: existing tests *Doc Changes*: n/a *Release Notes*: n/a Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
alyssawilk
reviewed
Sep 5, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Thanks for the fix!
On some level I'd rather we expose this in the state() of the connection, but that'd be a super high risk change and probably be worth it for deflaking :-P
one nit and you're good to go
test/integration/utility.h
Outdated
|
|
||
| Api::ApiPtr api_; | ||
| Event::DispatcherPtr dispatcher_; | ||
| std::shared_ptr<ConnectionCallbacks> callbacks_; |
Contributor
There was a problem hiding this comment.
Does this need to be a shared pointer, or can we get away with unique?
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
alyssawilk
approved these changes
Sep 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OS X's localhost interface often takes longer to fail to connect
than Linux. Modifies RawConnectionDriver to detect when its
underlying connection is connected or failed and pauses the
echo_integration_test until that state is reached before
checking the connection state.
Risk Level: low, test-only changes
Testing: existing tests
Doc Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher stephan@turbinelabs.io