Skip to content
Closed
Changes from 2 commits
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
7166095
add forward_original_sni to upstream TLS Context
vadimeisenbergibm Sep 4, 2018
8e298cc
reorder the fields in UpstreamTlsContext, put forward_original_sni last
vadimeisenbergibm Sep 5, 2018
fea6a13
remove TODO related to oneof and clarified the configuration
vadimeisenbergibm Sep 6, 2018
2f39451
add Network::ConnectionSocket::OptionsSharedPtr parameter to createTr…
vadimeisenbergibm Sep 6, 2018
3cc57db
fix format
vadimeisenbergibm Sep 9, 2018
f90f771
Add forward-original-sni to context_config
ronensc Sep 16, 2018
1d8578a
Revert "fix format"
vadimeisenbergibm Oct 10, 2018
5e7bed7
Revert "add Network::ConnectionSocket::OptionsSharedPtr parameter to …
vadimeisenbergibm Oct 10, 2018
f8b4f60
Revert "Add forward-original-sni to context_config"
vadimeisenbergibm Oct 10, 2018
26eb6fb
add forwardOriginalServerNameIndication() to ClusterInfo
vadimeisenbergibm Oct 10, 2018
7c37d51
add overrideServerNameIndication parameter to SslSocket and Context
vadimeisenbergibm Oct 10, 2018
ba9ff7d
add forwardOriginalServerNameIndication() to MockClusterInfo
vadimeisenbergibm Oct 11, 2018
35945a4
add overrideServerNameIndication to TransportSocketFactory::createTra…
vadimeisenbergibm Oct 11, 2018
3f927b1
update MockTransportSocketFactory::createTransportSocket()
vadimeisenbergibm Oct 11, 2018
cfcc5ee
fix TsiSocketFactory::createTransportSocket()
vadimeisenbergibm Oct 11, 2018
f0c1725
add overrideServerNameIndication to Host::createConnection()
vadimeisenbergibm Oct 11, 2018
baced96
remove unused parameter name
vadimeisenbergibm Oct 11, 2018
8f40ece
pass the SNI from the downstream connection to createConnection
vadimeisenbergibm Oct 11, 2018
aae6a12
add the SNI to the hash key
vadimeisenbergibm Oct 11, 2018
567552d
add the requested server name to the hash key in tcpConnPool instead …
vadimeisenbergibm Oct 13, 2018
09b8738
add a null pointer check
vadimeisenbergibm Oct 15, 2018
77de8e7
use absl::optional<std::string> instead of string with default
vadimeisenbergibm Oct 15, 2018
e7f5948
fix createConnection in test/mocks/upstream/host.h
vadimeisenbergibm Oct 16, 2018
f7249b2
fix MockTransportSocketFactory::createTransportSocket()
vadimeisenbergibm Oct 16, 2018
798a655
fix call to createTransportSocket in grpc_client_integration_test_har…
vadimeisenbergibm Oct 16, 2018
97057e9
a bug fix, inversing the result of optional::has_value()
vadimeisenbergibm Oct 16, 2018
9f9fbe8
pass optional instead of its value as a parameter
vadimeisenbergibm Oct 16, 2018
9a2a41e
more cases of passing optional instead of its value as a parameter
vadimeisenbergibm Oct 16, 2018
b44433d
another case of passing optional instead of its value as a parameter
vadimeisenbergibm Oct 16, 2018
1ed9359
add overrideServerName parameter to TCP ConnPool::ConnPool
vadimeisenbergibm Oct 16, 2018
c1d4228
fix TcpConnPoolImplDestructorTest
vadimeisenbergibm Oct 16, 2018
cb4ecb8
add overrideServerName parameter to allocateTcpConnPool()
vadimeisenbergibm Oct 17, 2018
7a0fb8b
fix MOCK_METHOD cardinality for allocateTcpConnPool
vadimeisenbergibm Oct 17, 2018
932d043
remove unnecessary initialization of an optional
vadimeisenbergibm Oct 17, 2018
320e435
add a check that requestedServerName is not empty
vadimeisenbergibm Oct 17, 2018
c7a32d0
assign to optional by operator=(), not by value()
vadimeisenbergibm Oct 18, 2018
e9fc3a1
Merge branch 'master' into forward_original_sni
vadimeisenbergibm Oct 21, 2018
3da1148
add OriginalRequestedServerName filter state object, and use it the f…
vadimeisenbergibm Oct 22, 2018
8d8b39c
add envoy.filters.network.original_sni
vadimeisenbergibm Oct 22, 2018
325855f
add a check that a parameter is not null
vadimeisenbergibm Oct 23, 2018
740bfd3
remove redundant check
vadimeisenbergibm Oct 23, 2018
45aed66
Merge branch 'master' into forward_original_sni
vadimeisenbergibm Oct 23, 2018
19a6e0d
overrideServerName -> override_server_name
vadimeisenbergibm Oct 23, 2018
7e18f1c
add override_server_name parameter to tcpConnForCluster and tcpConnPo…
vadimeisenbergibm Oct 24, 2018
233bc5f
fix mock method's cardinality
vadimeisenbergibm Oct 28, 2018
5e704fb
fix lambda parameters in test
vadimeisenbergibm Oct 28, 2018
af8e96f
Merge branch 'master' into forward_original_sni
vadimeisenbergibm Oct 28, 2018
460e84a
add missing include of absl::optional
vadimeisenbergibm Oct 29, 2018
5bccf5c
fix formatting
vadimeisenbergibm Oct 29, 2018
6d1ff22
fix a call to setData() method
vadimeisenbergibm Oct 29, 2018
365bf98
remove polling filterState for original sni
vadimeisenbergibm Oct 31, 2018
d2857ea
Revert "remove polling filterState for original sni"
vadimeisenbergibm Oct 31, 2018
4a11d1f
use using instead of typedef
vadimeisenbergibm Oct 31, 2018
1dbef57
add ON_CALL for const filterState() mock method
vadimeisenbergibm Oct 31, 2018
cbf26fa
add missing using for testing::Const
vadimeisenbergibm Oct 31, 2018
616c91b
fix syntax of using directives
vadimeisenbergibm Oct 31, 2018
5d9b559
Revert "add forwardOriginalServerNameIndication() to MockClusterInfo"
vadimeisenbergibm Oct 31, 2018
809c74f
Revert "add forwardOriginalServerNameIndication() to ClusterInfo"
vadimeisenbergibm Oct 31, 2018
f41f7c0
Revert "remove TODO related to oneof and clarified the configuration"
vadimeisenbergibm Oct 31, 2018
ac4278a
Revert "reorder the fields in UpstreamTlsContext, put forward_origina…
vadimeisenbergibm Oct 31, 2018
9217a85
Revert "add forward_original_sni to upstream TLS Context"
vadimeisenbergibm Oct 31, 2018
7150d92
original_requested_server_name -> forward_requested_server_name
vadimeisenbergibm Nov 1, 2018
74bdc7e
OriginalRequestedServerName -> ForwardRequestedServerName
vadimeisenbergibm Nov 1, 2018
d441cda
source/extensions/filters/network/original_sni -> source/extensions/f…
vadimeisenbergibm Nov 1, 2018
bfea2ff
OriginalSniNetworkFilter -> ForwardOriginalSniNetworkFilter
vadimeisenbergibm Nov 1, 2018
123f591
use auto variable qualifier
vadimeisenbergibm Nov 1, 2018
5ab3ad2
add test for forward_original_sni network filter
vadimeisenbergibm Nov 1, 2018
e4a44c6
fix a typo
vadimeisenbergibm Nov 1, 2018
e24ff66
add using declaration for ForwardRequestedServerName
vadimeisenbergibm Nov 1, 2018
4ea35c7
fix additional typo
vadimeisenbergibm Nov 1, 2018
2590146
add initial version of CreateTransportSocketWithOverrideServerName
vadimeisenbergibm Nov 1, 2018
50a5091
fix CreateTransportSocketWithOverrideServerName test
vadimeisenbergibm Nov 1, 2018
b53e88a
use get() to extract the pointer from uniq_ptr
vadimeisenbergibm Nov 2, 2018
b748e80
use connection to test ssl socket
vadimeisenbergibm Nov 2, 2018
60b04e0
remove checking client_session
vadimeisenbergibm Nov 2, 2018
4e7601a
remove transport_socket temprary variable
vadimeisenbergibm Nov 2, 2018
6fd2102
add check that client_connection is not nullptr
vadimeisenbergibm Nov 2, 2018
53ee9a5
Revert "add check that client_connection is not nullptr"
vadimeisenbergibm Nov 2, 2018
c890c3b
Revert "remove transport_socket temprary variable"
vadimeisenbergibm Nov 2, 2018
9e6966a
Revert "remove checking client_session"
vadimeisenbergibm Nov 2, 2018
2667505
Revert "use connection to test ssl socket"
vadimeisenbergibm Nov 2, 2018
13e8101
Revert "use get() to extract the pointer from uniq_ptr"
vadimeisenbergibm Nov 2, 2018
652c050
Revert "fix CreateTransportSocketWithOverrideServerName test"
vadimeisenbergibm Nov 2, 2018
b9fd493
Revert "add initial version of CreateTransportSocketWithOverrideServe…
vadimeisenbergibm Nov 2, 2018
ce243f4
add override_server_name_parameter to testUtilV2
vadimeisenbergibm Nov 2, 2018
0f7d564
fix erroneous parameters to testUtil
vadimeisenbergibm Nov 2, 2018
fa2df04
add OverrideRequestedServerName test
vadimeisenbergibm Nov 2, 2018
4a7c8e6
check the SNI in the client SSL
vadimeisenbergibm Nov 2, 2018
a96f40f
optional hasValue() -> has_value()
vadimeisenbergibm Nov 2, 2018
4fd8156
fix a variable name
vadimeisenbergibm Nov 2, 2018
68e15df
fix format
vadimeisenbergibm Nov 2, 2018
4e5648a
remove applying SSL_get_servername on the client
vadimeisenbergibm Nov 4, 2018
e560b74
rename ForwardRequestedServerName::Key
vadimeisenbergibm Nov 4, 2018
1613f42
update docs and CODEOWNERS
vadimeisenbergibm Nov 4, 2018
502f9d3
Merge branch 'master' into forward_original_sni
vadimeisenbergibm Nov 4, 2018
548c063
add missing parameter to createTransportSocket()
vadimeisenbergibm Nov 4, 2018
c9d3673
add tcp proxy ForwardRequestedServerName
vadimeisenbergibm Nov 4, 2018
45734c0
fix a comment
vadimeisenbergibm Nov 5, 2018
127bce3
set local address for the connection in ForwardRequestedServerName test
vadimeisenbergibm Nov 5, 2018
2e4a8da
use WillOnce(Invoke) to test the override_server_name
vadimeisenbergibm Nov 5, 2018
0c7a948
fix parameters of the lambda in Invoke of ForwardRequestServerName
vadimeisenbergibm Nov 5, 2018
f01b818
fix the key of ForwardRequestedServerName
vadimeisenbergibm Nov 5, 2018
e63a960
add extracting the requested server name from the server side SSL object
vadimeisenbergibm Nov 5, 2018
7b28148
add OverrideRequestedServerNameWithoutSniInUpstreamTlsContext test
vadimeisenbergibm Nov 5, 2018
0dc8998
fix format
vadimeisenbergibm Nov 5, 2018
46dd604
add passing nonempty value of override_server_name in UnknownCluster …
vadimeisenbergibm Nov 5, 2018
89ce5fc
add DynamicHostRemoveWithTls test
vadimeisenbergibm Nov 5, 2018
d44e6f2
tlsContext -> ssl_context according to the json schema
vadimeisenbergibm Nov 5, 2018
c2fada8
remove ssl_context from DynamicHostRemoveWithTls
vadimeisenbergibm Nov 5, 2018
25c1aa6
move setting hash key by the override_server_name field out of contai…
vadimeisenbergibm Nov 5, 2018
7bb1793
fix a counter value due to changes
vadimeisenbergibm Nov 5, 2018
ca99513
add drained cb for example.com and ibm.com connection pools
vadimeisenbergibm Nov 5, 2018
6b8ea04
fix the number of drained connection pools
vadimeisenbergibm Nov 6, 2018
08602ac
add vadimeisenbergibm to code owners of forward_original_sni extension
vadimeisenbergibm Nov 6, 2018
7ccaf1d
extract override_server_name functionality into a separate PR
vadimeisenbergibm Nov 6, 2018
0f13892
extract override_server_name functionality into a separate PR, leftovers
vadimeisenbergibm Nov 6, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/envoy/api/v2/auth/cert.proto
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,11 @@ message UpstreamTlsContext {
//
// TLS renegotiation is considered insecure and shouldn't be used unless absolutely necessary.
bool allow_renegotiation = 3;

// If true, the SNI from the downstream connection is forwarded to the upstream connection.
//
// TODO: handle oneof with the sni
bool forward_original_sni = 4;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this?

}

message DownstreamTlsContext {
Expand Down