Skip to content

Revert "Ignore health_check.proto"

45098c5
Select commit
Loading
Failed to load commit list.
Open

Add retriable_serving_statuses to grpc health check to support retrying NOT_SERVING #43331

Revert "Ignore health_check.proto"
45098c5
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Coverage skipped Mar 25, 2026 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/43331/main@45098c5)

fishcakez @fishcakez 45098c5 #43331 merge main@6874e47

Add retriable_serving_statuses to grpc health check to support retrying NOT_SERVING

Commit Message: Add retriable_serving_statuses to gRPC health check to support retrying NOT_SERVING
Additional Description: Add retriable_serving_statuses to gRPC health check to mimic the HTTP health check retriable_statuses, See #17948. This supports the case where want a NOT_SERVING gRPC response to honor the unhealthy_threshold instead of immediately failing.
Risk Level: low - requires enabling to change behavior
Testing: unit, integration and fuzzing changes
Docs Changes: API has inline doc but not health check architecture doc (awaiting review first)
Release Notes: Not updated yet.
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue] N/A
[Optional Fixes commit #PR or SHA] N/A
[Optional Deprecated:] N/A
[Optional API Considerations:] imports gRPC health check proto, may be control plane implications/build changes needed when its brought in. Note that buf linter cannot handle the import due to difference between grpc/grpc and grpc/grpc-proto so skip linting the file for now. Also PGV has issues with repeated enum validation in cc and go, so validate explicit in config load logic.

Environment

Request variables

Key Value
ref 167f0c6
sha 45098c5
pr 43331
base-sha 6874e47
actor fishcakez @fishcakez
message Add retriable_serving_statuses to grpc health check to support retrying NOT_SERVING...
started 1774461830.359838
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default docker.io/envoyproxy/envoy-build:86873047235e9b8232df989a5999b9bebf9db69c
mobile docker.io/envoyproxy/envoy-build:mobile-86873047235e9b8232df989a5999b9bebf9db69c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 38
patch 0
dev true