Skip to content

test: set to zero when start_time exceeds limit #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 4 commits into from
Sep 4, 2018
Merged

test: set to zero when start_time exceeds limit #4328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd3a23a
test: set to zero when start_time exceeds limit
dio Sep 1, 2018
e314a2a
Add access_log_formatter related corpus
dio Sep 1, 2018
8085d7c
Fix newline
dio Sep 1, 2018
a430a44
Change to nanoseconds
dio Sep 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ter_corpus/clusterfuzz-testcase-minimized-access_log_formatter_fuzz_test-5701824317751296
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
format: "%START_TIME(%f)%" request_info { start_time: 18446744073709551615 }
1 change: 1 addition & 0 deletions ...der_parser_corpus/clusterfuzz-testcase-minimized-header_parser_fuzz_test-5647641023610880
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
headers_to_add { header { key: " " value: "%START_TIME(�)%" } } request_info { start_time: 9799832698963886077 }
7 changes: 5 additions & 2 deletions test/fuzz/utility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,11 @@ inline TestRequestInfo fromRequestInfo(const test::fuzz::RequestInfo& request_in
TestRequestInfo test_request_info;
test_request_info.metadata_ = request_info.dynamic_metadata();
// libc++ clocks don't track at nanosecond on OS X.
test_request_info.start_time_ =
SystemTime(std::chrono::microseconds(request_info.start_time() / 1000));
const auto start_time =
std::numeric_limits<std::chrono::nanoseconds::rep>::max() < request_info.start_time()
? 0
: request_info.start_time() / 1000;
test_request_info.start_time_ = SystemTime(std::chrono::microseconds(start_time));
if (request_info.has_response_code()) {
test_request_info.response_code_ = request_info.response_code().value();
}
Expand Down