tcp_proxy: add log on start#43140
Merged
kyessenov merged 5 commits intoenvoyproxy:mainfrom Jan 25, 2026
Merged
Conversation
Change-Id: Ib8485b0d970f05dc9e4f93b01f8dfd81c54662dd Signed-off-by: Kuat Yessenov <kuat@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Change-Id: I064939e1c6c455385a9fe3b4a34dff30e56a4598 Signed-off-by: Kuat Yessenov <kuat@google.com>
TAOXUY
approved these changes
Jan 24, 2026
agrawroh
previously approved these changes
Jan 24, 2026
| // connection with the upstream. If the connection fails, the access log is not flushed. | ||
| bool flush_access_log_on_connected = 2; | ||
|
|
||
| // If set to true, the access log is flushed when the TCP proxy accepts a connection. |
Member
There was a problem hiding this comment.
Suggested change
| // If set to true, the access log is flushed when the TCP proxy accepts a connection. | |
| // If set to ``true``, the access log is flushed when the TCP proxy accepts a connection. |
Contributor
Author
There was a problem hiding this comment.
I copied from above - probably need to revise the whole proto.
Member
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
mattklein123
previously approved these changes
Jan 24, 2026
Change-Id: I55a2a3c7d7c2475866396717996882e3d88244af
agrawroh
approved these changes
Jan 24, 2026
Change-Id: I4643d98f4c3d75f2fa89061ac3f242f9c0f75e13
shane-yuan
pushed a commit
to shane-yuan/envoy
that referenced
this pull request
Feb 11, 2026
Change-Id: Ib8485b0d970f05dc9e4f93b01f8dfd81c54662dd Commit Message: Add ability to log connection starts in TCP proxy. This coupled with envoyproxy#42226 should provide "almost" exact active connection gauge. (The problematic edge case is when a prior filter stops iteration in `onNewConnection` or a disconnect happens prior to reaching `tcp_proxy` - that requires unusual config). Risk Level: low Testing: added Docs Changes: yes Release Notes: yes --------- Signed-off-by: Kuat Yessenov <kuat@google.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Change-Id: Ib8485b0d970f05dc9e4f93b01f8dfd81c54662dd Commit Message: Add ability to log connection starts in TCP proxy. This coupled with envoyproxy#42226 should provide "almost" exact active connection gauge. (The problematic edge case is when a prior filter stops iteration in `onNewConnection` or a disconnect happens prior to reaching `tcp_proxy` - that requires unusual config). Risk Level: low Testing: added Docs Changes: yes Release Notes: yes --------- Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib8485b0d970f05dc9e4f93b01f8dfd81c54662dd
Commit Message: Add ability to log connection starts in TCP proxy. This coupled with #42226 should provide "almost" exact active connection gauge. (The problematic edge case is when a prior filter stops iteration in
onNewConnectionor a disconnect happens prior to reachingtcp_proxy- that requires unusual config).Risk Level: low
Testing: added
Docs Changes: yes
Release Notes: yes