ratelimit: check for initiating call before continue decoding#4287
ratelimit: check for initiating call before continue decoding#4287ramaraochavali wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
|
@junr03 see if this helps the crash you are seeing. I am not fully familiar with network filter - so not sure if that condition check is required, but please review. If it does not, please feel free to revert the original commit. |
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
Please add test coverage for this case.
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
No worries. Sorry, I forgot to update the original PR yesterday. Yes, I fixed at Lyft by doing what you are now proposing here.
As @ggreenway says, please add test coverage for this. Thanks!
|
@ramaraochavali Lyft wants to get envoy to a clean state, so while we create tests here and get this merged we are going to revert. Here is the PR #4295. You'll just have to rebase master once that lands. Thanks! |
|
Merge conflicts. The original change was backed out. Probably the easiest way to fix is to close this PR and create a new one, backout the backout, then apply this change on top of it. |
|
I will close this PR and open another one. |
3 participants
Signed-off-by: Rama rama.rao@salesforce.com
Description: To check for initiating call before continue decoding. See #4073 (comment) for more details to avoid the crash
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]