Skip to content

build: fixing a downstream compile error by noting explicit fallthrough #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 1 commit into from
Aug 27, 2018
Merged

build: fixing a downstream compile error by noting explicit fallthrough #4265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/common/http/header_map_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ void HeaderString::setInteger(uint64_t value) {
case Type::Inline:
// buffer_.dynamic_ should always point at inline_buffer_ for Type::Inline.
ASSERT(buffer_.dynamic_ == inline_buffer_);
FALLTHRU;
case Type::Dynamic: {
// Whether dynamic or inline the buffer is guaranteed to be large enough.
ASSERT(type_ == Type::Inline || dynamic_capacity_ >= MaxIntegerLength);
Expand Down