Skip to content

test: Wrap proto string in std::string before comparison #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 2 commits into from
Aug 27, 2018
Merged

test: Wrap proto string in std::string before comparison #4238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e66de
test: Wrap proto string in std::string before comparison.
jamessynge Aug 23, 2018
45fcc7a
Wrap proto string value with absl::string_view
jamessynge Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/integration/hds_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,9 @@ class HdsIntegrationTest : public HttpIntegrationTest,
if (address->ip()->port() != endpoint.endpoint().address().socket_address().port_value()) {
return false;
}
// SocketAddress.address is a proto string, not std::string, so convert it before comparing.
if (address->ip()->addressAsString() !=
endpoint.endpoint().address().socket_address().address()) {
absl::string_view(endpoint.endpoint().address().socket_address().address())) {
return false;
}
return true;
Expand Down