Skip to content

Bump yaml-cpp so it builds with Visual Studio 15.8 #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 2 commits into from
Aug 16, 2018
Merged

Bump yaml-cpp so it builds with Visual Studio 15.8 #4182

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa21faf
Bump yaml-cpp so it builds with Visual Studio 15.8
sesmith177 Aug 16, 2018
786432f
Use curl instead of git clone
sesmith177 Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ci/build_container/build_recipes/yaml-cpp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

set -e

VERSION=0.6.2
# Pin to this commit to pick up fix for building on Visual Studio 15.8
COMMIT=0f9a586ca1dc29c2ecb8dd715a315b93e3f40f79 # 2018-06-30

curl https://github.com/jbeder/yaml-cpp/archive/yaml-cpp-"$VERSION".tar.gz -sLo yaml-cpp-"$VERSION".tar.gz
tar xf yaml-cpp-"$VERSION".tar.gz
cd yaml-cpp-yaml-cpp-"$VERSION"
git clone https://github.com/jbeder/yaml-cpp

@mattklein123 mattklein123 Aug 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a way to still download a tarball from GH even with a specific SHA, but I don't recall the method off the top of my head (check out history of other build recipe files). cc @jmillikin-stripe @PiotrSikora

cd yaml-cpp
git reset --hard "$COMMIT"

mkdir build
cd build
Expand Down