-
Notifications
You must be signed in to change notification settings - Fork 5.2k
xds: add config for random_subsetting LB policy extension #41758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @Zgoda91, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
markdroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
api/envoy/extensions/load_balancing_policies/random_subsetting/v3/random_subsetting.proto
Show resolved
Hide resolved
implementing [gRFC A68](https://github.com/grpc/proposal/blob/master/A68-random-subsetting.md) This change contains: 1. Usage of `murmur3_128` hashing algorithm from Guava library. 2. Implementation of `RandomSubsettingLoadBalancer` and `RandomSubsettingLoadBalancerProvider` classes and integration into the `util` project. Since envoy extensions does not support `random_subsetting` LB policy yet, xDS related changes will be introduced later. Envoy PR [here](envoyproxy/envoy#41758).
|
@wbpcode PTAL |
Commit Message: xds: add config for random_subsetting LB policy extension
Additional Description: This PR adds new LB policy extension configuration, to be used in gRPC via the new load_balancing_policy field:
random_subsetting: This policy selects a subset of endpoints and passes them to the child LB policy.Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A