build: use clang-6.0.#4168
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Aug 16, 2018
Merged
Conversation
Contributor
Author
|
Note: this is the follow-up to #4157, so it won't build before the other one is merged. |
*Risk Level*: Medium (we're dropping support for CentOS build image). *Testing*: Successful build using new image. *Docs Changes*: n/a *Release Notes*: n/a Closes envoyproxy#3937. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
Also, I've split actual changes (1st commit) from the |
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, nice. This is going to probably cause a series of broken master merges w/ the format changes, so when this merges we should probably try to get everyone to merge master into their PRs. @envoyproxy/maintainers
| @@ -17,9 +17,9 @@ function setup_gcc_toolchain() { | |||
| } | |||
|
|
|||
| function setup_clang_toolchain() { | |||
Member
There was a problem hiding this comment.
Per @lizan might as well just start linking w/ lld for the cases where we use clang today? Or prefer to defer to a separate PR?
Member
There was a problem hiding this comment.
Let's defer that to a separate PR, IIRC we hardcoded gold in some bzl files.
Contributor
Author
There was a problem hiding this comment.
Definitely a separate PR. I believe that Bazel hardcodes -fuse-ld=gold somewhere as well, but maybe that's easy to override.
Member
There was a problem hiding this comment.
It's pretty trivial using bazelrc but agree let's do in a follow up.
Member
There was a problem hiding this comment.
@mattklein123 using bazelrc is a quick set up to speed up local building, I would like to also fix https://github.com/envoyproxy/envoy/blob/master/bazel/genrule_repository.bzl#L108 to land lld in master.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
mattklein123
approved these changes
Aug 16, 2018
Contributor
Author
|
Tests passed, this should be good to merge. Thanks! |
Closed
snowp
pushed a commit
to snowp/envoy
that referenced
this pull request
Aug 20, 2018
* origin/master: (34 commits) fuzz: fixes oss-fuzz: 9895 (envoyproxy#4189) docs: added developer docs for pprof/tcmalloc testing (envoyproxy#4194) fix sometimes returns response body to HEAD requests (envoyproxy#3985) admin: fix config dump order (envoyproxy#4197) thrift: allow translation between downstream and upstream protocols (envoyproxy#4136) Use local_info.node() instead of bootstrap.node() whenever possible (envoyproxy#4120) upstream: allow extension protocol options to be used with http filters (envoyproxy#4165) [thrift_proxy] Replace local HeaderMap with Http::HeaderMap[Impl] (envoyproxy#4169) docs: improve gRPC-JSON filter doc (envoyproxy#4184) stats: refactoring MetricImpl without strings (envoyproxy#4190) fuzz: coverage profile generation instructions. (envoyproxy#4193) upstream: rebuild cluster when health check config is changed (envoyproxy#4075) build: use clang-6.0. (envoyproxy#4168) thrift_proxy: introduce header transport (envoyproxy#4082) tcp: allow connection pool callers to store protocol state (envoyproxy#4131) configs: match latest API changes (envoyproxy#4185) Fix wrong mock function name. (envoyproxy#4187) Bump yaml-cpp so it builds with Visual Studio 15.8 (envoyproxy#4182) Converting envoy configs to V2 (envoyproxy#2957) Add timestamp to HealthCheckEvent definition (envoyproxy#4119) ... Signed-off-by: Snow Pettersen <snowp@squareup.com>
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…#1938) This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/envoyproxy/envoy: c1cc68d stats: refactoring MetricImpl without strings (envoyproxy#4190) 36809d8 fuzz: coverage profile generation instructions. (envoyproxy#4193) ba40cc9 upstream: rebuild cluster when health check config is changed (envoyproxy#4075) 05c0d52 build: use clang-6.0. (envoyproxy#4168) 01f403e thrift_proxy: introduce header transport (envoyproxy#4082) 564d256 tcp: allow connection pool callers to store protocol state (envoyproxy#4131) 3e1d643 configs: match latest API changes (envoyproxy#4185) bc6a10c Fix wrong mock function name. (envoyproxy#4187) e994c1c Bump yaml-cpp so it builds with Visual Studio 15.8 (envoyproxy#4182) 3d1325e Converting envoy configs to V2 (envoyproxy#2957) 8d0680f Add timestamp to HealthCheckEvent definition (envoyproxy#4119) 497efb9 server: handle non-EnvoyExceptions safely if thrown in constructor. (envoyproxy#4173) 6d6fafd config: strengthen validation for gRPC config sources. (envoyproxy#4171) 132302c fuzz: reduce log level when running under fuzz engine. (envoyproxy#4161) 7c04ac2 test: fix V6EmptyOptions in coverage with IPv6 enable (envoyproxy#4155) 1b2219b ci: remove deprecated bazel --batch option (envoyproxy#4166) 2db6a4c ci: update clang to version 6.0 in the Ubuntu build image. (envoyproxy#4157) 71152b7 ratelimit: Add ratelimit custom response headers (envoyproxy#4015) 3062874 ssl: make Ssl::Connection const everywhere (envoyproxy#4179) 706e262 Handle validation of non expiring tokens in jwt_authn filter (envoyproxy#4007) f06e958 fuzz: tag trivial fuzzers with no_fuzz. (envoyproxy#4156) 27fb1d3 thrift_proxy: add service name matching to router implementation (envoyproxy#4130) 8c189a5 Make over provisioning factor configurable (envoyproxy#4003) 6c08fb4 Making test less flaky (envoyproxy#4149) 592775b fuzz: bare bones HCM fuzzer. (envoyproxy#4118) For istio/istio#7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Medium (we're dropping support for CentOS build image).
Testing: Successful build using new image.
Docs Changes: n/a
Release Notes: n/a
Closes #3937.
Signed-off-by: Piotr Sikora piotrsikora@google.com