Merged
Conversation
*Risk Level*: low *Testing*: tests pass *Docs Changes*: n/a *Release Notes*: n/a Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
zuercher
commented
Aug 14, 2018
| namespace { | ||
| const Envoy::Http::HeaderMapImpl empty_header = Envoy::Http::HeaderMapImpl(); | ||
| const envoy::api::v2::core::Metadata empty_metadata = envoy::api::v2::core::Metadata(); | ||
| const Envoy::Http::HeaderMapImpl empty_header; |
Member
Author
There was a problem hiding this comment.
I suppose these should actually be constructed-on-first-use.
Member
There was a problem hiding this comment.
yeah I have a change for it, up to you to change this here or I will open another PR
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
snowp
pushed a commit
to snowp/envoy
that referenced
this pull request
Aug 14, 2018
* origin/master: http_filter: add addEncodedTrailers and addDecodedTrailers (envoyproxy#3980) rbac/fuzz: fix build (envoyproxy#4150) Signed-off-by: Snow Pettersen <snowp@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4083 and #4116 conflicted with #4129
Risk Level: low
Testing: tests pass
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher stephan@turbinelabs.io