rbac: fix flaky integration test.#4147
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 14, 2018
Merged
Conversation
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
Contributor
Author
|
/cc @alyssawilk |
alyssawilk
approved these changes
Aug 14, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Fantastic - thanks for the quick fix!
lizan
approved these changes
Aug 14, 2018
Contributor
|
Bah. tsan build has failed 3 times with hds and echo integration test failures (both open flake bugs). Running again. This might be worth a force merge @htuch / @mattklein123 once we have the build fixed. |
Member
|
done |
snowp
pushed a commit
to snowp/envoy
that referenced
this pull request
Aug 14, 2018
* origin/master: fix flaky RBAC integration test. (envoyproxy#4147) header_map: copy constructor for HeaderMapImpl. (envoyproxy#4129) test: moving websocket tests to using HTTP codec. (envoyproxy#4143) upstream: init host hc value based on hc value from other priorities (envoyproxy#3959) Signed-off-by: Snow Pettersen <snowp@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yangmin Zhu ymzhu@google.com
Description: Fix flaky tests.
Risk Level: Low
Testing:
The flaky tests could be reproduced by running:
bazel test //test/extensions/filters/network/rbac:integration_test --jobs 60 --runs_per_test=3000 --local_resources 100000000000,100000000000,10000000 --cache_test_results=noand confirmed this doesn't reproduce anymore after this fix.Docs Changes: N/A
Release Notes: N/A
Fixes #4146