add override knob for stream flush timeout#40811
Merged
wbpcode merged 7 commits intoenvoyproxy:mainfrom Aug 27, 2025
Merged
Conversation
Signed-off-by: antoniovleonti <leonti@google.com>
antoniovleonti
requested review from
mattklein123 and
yanavlasov
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: antoniovleonti <leonti@google.com>
Member
|
Thanks for this contribution. That make sense for me. But I am OOO this week. If you in a hurry, may could try ping another api shepherd/maintainer to review this API/core code. |
wbpcode
reviewed
Aug 22, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM overall, thanks for the contribution! And some comments are added.
Signed-off-by: antoniovleonti <leonti@google.com>
Signed-off-by: antoniovleonti <leonti@google.com>
Signed-off-by: antoniovleonti <leonti@google.com>
Signed-off-by: antoniovleonti <leonti@google.com>
Contributor
Author
|
/retest |
Contributor
Author
|
Ping! |
wbpcode
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add override knob for stream flush timeout
Additional Description:
Today it is not possible to configure the stream idle timeout and the stream flush timeout (i.e. the time envoy will wait for the downstream client to open enough window for its response) independently. This PR makes it possible to configure an explicit flush timeout. It also maintains the current behavior of allowing you to configure it just through the stream idle timeout knob for backwards compatibility.
Risk Level: low