Validate ext_authz OkResponse header append actions#40650
Merged
kyessenov merged 4 commits intoenvoyproxy:mainfrom Sep 2, 2025
Merged
Validate ext_authz OkResponse header append actions#40650kyessenov merged 4 commits intoenvoyproxy:mainfrom
kyessenov merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: antoniovleonti <leonti@google.com>
Signed-off-by: antoniovleonti <leonti@google.com>
Contributor
Author
|
/assign-from @envoyproxy/first-pass-reviewers |
|
@envoyproxy/first-pass-reviewers assignee is @yanjunxiang-google |
Signed-off-by: antoniovleonti <leonti@google.com>
antoniovleonti
force-pushed
the
ext_authz_panic
branch
from
255dd75 to
b998235
Compare
Contributor
|
LGTM |
yanjunxiang-google
approved these changes
Aug 25, 2025
Contributor
Author
|
/assign ggreenway |
barroca
pushed a commit
to barroca/envoy
that referenced
this pull request
Sep 9, 2025
Commit Message: Validate ext_authz OkResponse header append actions Additional Description: This PR adds validation (and removes sentinel value check) to the ext authz grpc client. If an invalid header append action is found and validate_mutations is true, the response and thus downstream request will be rejected. If validation_mutations is false, invalid actions are ignored. Risk Level: low Testing: unit / integration tests added --------- Signed-off-by: antoniovleonti <leonti@google.com> Signed-off-by: Leonardo da Mata <ldamata@spotify.com>
shane-yuan
pushed a commit
to shane-yuan/envoy
that referenced
this pull request
Sep 9, 2025
Commit Message: Validate ext_authz OkResponse header append actions Additional Description: This PR adds validation (and removes sentinel value check) to the ext authz grpc client. If an invalid header append action is found and validate_mutations is true, the response and thus downstream request will be rejected. If validation_mutations is false, invalid actions are ignored. Risk Level: low Testing: unit / integration tests added --------- Signed-off-by: antoniovleonti <leonti@google.com>
mbadov
pushed a commit
to mbadov/envoy
that referenced
this pull request
Sep 22, 2025
Commit Message: Validate ext_authz OkResponse header append actions Additional Description: This PR adds validation (and removes sentinel value check) to the ext authz grpc client. If an invalid header append action is found and validate_mutations is true, the response and thus downstream request will be rejected. If validation_mutations is false, invalid actions are ignored. Risk Level: low Testing: unit / integration tests added --------- Signed-off-by: antoniovleonti <leonti@google.com> Signed-off-by: Misha Badov <mbadov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Validate ext_authz OkResponse header append actions
Additional Description:
This PR adds validation (and removes sentinel value check) to the ext authz grpc client. If an invalid header append action is found and validate_mutations is true, the response and thus downstream request will be rejected. If validation_mutations is false, invalid actions are ignored.
Risk Level: low
Testing: unit / integration tests added