Rename duplicated ads integration test case name#4035
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Aug 2, 2018
dio:rename-ads-test-case
Merged
Rename duplicated ads integration test case name#4035mattklein123 merged 2 commits intoenvoyproxy:masterfrom dio:rename-ads-test-case
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
dio:rename-ads-test-case
Conversation
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
mattklein123
reviewed
Aug 2, 2018
|
|
||
| // Validate that the request with duplicate listeners is rejected. | ||
| TEST_P(AdsIntegrationTest, DuplicateWarmingClusters) { | ||
| TEST_P(AdsIntegrationTest, RejectDuplicateWarmingClusters) { |
Member
There was a problem hiding this comment.
I think this should be DuplicateWarmingListeners or something like that? cc @ramaraochavali
Member
Author
There was a problem hiding this comment.
Ah yeah, re-read the code and it should be like suggested. Thanks.
Contributor
There was a problem hiding this comment.
Oops... Sorry @mattklein123 . while preventing duplicates ended up adding a duplicate (test name). :-(
@dio Thanks for correcting this.
mattklein123
approved these changes
Aug 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rename the duplicated DuplicateWarmingClusters test case, here and here.
Risk Level: Low
Testing: Current tests
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Dhi Aurrahman dio@tetrate.io