docs: fix grammar errors#3983
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jul 30, 2018
kakengloh:master
Merged
docs: fix grammar errors#3983mattklein123 merged 2 commits intoenvoyproxy:masterfrom kakengloh:master
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
kakengloh:master
Conversation
Fixed some grammatical errors of documentations Signed-off-by: kkloh98 <40446720+kkloh98@users.noreply.github.com>
CONTRIBUTING.md
Outdated
| We reserve the right to close PRs that are not making progress. This is generally defined as no | ||
| changes for 7 days. Obviously PRs that are closed due to lack of activity can be reopened later. | ||
| Closing stale PRs helps us keep on top of all of the work currently in flight. | ||
| Closing stale PRs help us to keep on top of all of the work currently in flight. |
Member
There was a problem hiding this comment.
nit: I think this reads better with what we previously had, or make it "helps us to"
you're right, seems like it sounds better Signed-off-by: kkloh98 <40446720+kkloh98@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some grammatical errors of documentations
Signed-off-by: kkloh98 40446720+kkloh98@users.noreply.github.com
Risk Level: Low
Testing: n/a
Docs Changes: STYLE.md, CONTRIBUTING.md, SECURITY_RELEASE_PROCESS.md, REPO_LAYOUT.md
Release Notes: n/a