build: Fix envoy-filter-example build#3947
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jul 24, 2018
greenhouse-org:fix-filter-windows
Merged
build: Fix envoy-filter-example build#3947htuch merged 1 commit intoenvoyproxy:masterfrom greenhouse-org:fix-filter-windows
htuch merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:fix-filter-windows
Conversation
Some of the references to "//bazel:windows_x86_64" were not properly prefixed with the repostory name, causing the build of envoy-filter-example to fail. Signed-off-by: Sam Smith <sesmith177@gmail.com>
Member
|
lgtm, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Some of the references to "//bazel:windows_x86_64" were not properly prefixed with the repostory name, causing the build of envoy-filter-example to fail.
Risk Level:
Low
Testing:
bazel test //test/...From
envoy-filter-example, ranbazel build //:envoyDocs Changes:
Release Notes: