Make DnsFilterTest.RandomizeFirstAnswerTest less brittle#39464
Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom May 15, 2025
Merged
Make DnsFilterTest.RandomizeFirstAnswerTest less brittle#39464yanavlasov merged 1 commit intoenvoyproxy:mainfrom
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
kyessenov
approved these changes
May 15, 2025
fishpan1209
pushed a commit
to fishpan1209/envoy
that referenced
this pull request
May 22, 2025
…39464) Use a different insertion and retrieval order into std::unordered_multimap. This fixes the problem where libstdc++ implementation starting in GCC13 always ends up producing the first address in the answer and causing the test to fail. Risk Level: Low Testing: Unit Test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Fixes envoyproxy#24330 Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ting Pan <panting@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a different insertion and retrieval order into std::unordered_multimap. This fixes the problem where libstdc++ implementation starting in GCC13 always ends up producing the first address in the answer and causing the test to fail.
Risk Level: Low
Testing: Unit Test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #24330