fuzz: fixes oss-fuzz: 9204#3935
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Jul 27, 2018
anirudhmurali:oss-fuzz-9204
Merged
fuzz: fixes oss-fuzz: 9204#3935htuch merged 3 commits intoenvoyproxy:masterfrom anirudhmurali:oss-fuzz-9204
htuch merged 3 commits intoenvoyproxy:masterfrom
anirudhmurali:oss-fuzz-9204
Conversation
zuercher
reviewed
Jul 23, 2018
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Looks good. Just one style nit.
Member
There was a problem hiding this comment.
I believe our style is to use curly braces around both the if and else statements in this case.
zuercher
reviewed
Jul 24, 2018
Member
There was a problem hiding this comment.
I think you need to delete log_manager.
htuch
reviewed
Jul 24, 2018
Member
There was a problem hiding this comment.
Ideally add a unit test in addition to the corpus, thanks.
Member
|
@anirudhmurali can you merge master to workaround the merge conflict here and push? Ta. |
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
htuch
approved these changes
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fixes oss-fuzz: 9204
Description: oss-fuzz issue (9204): https://oss-fuzz.com/v2/testcase-detail/5366294281977856
I suppose Envoy doesn't support multiple health checks still. Instead of assertion, have replaced it with throw. This doesn't crash the build. Let me know if any changes.
Risk Level: Low
Testing: Tested unit tests (bazel test //server:server_fuzz_test), built and ran fuzzers with oss-fuzz.
Signed-off-by: Anirudh M m.anirudh18@gmail.com