Update network utility getoriginaldst for IPv6#3933
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Jul 24, 2018
Merged
Conversation
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
Member
Author
added 2 commits
July 23, 2018 19:30
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
htuch
approved these changes
Jul 24, 2018
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks for routing around the DCO issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com
title: Update network utility getoriginaldst for IPv6
Description:
This PR adds IP6T_SO_ORIGINAL_DST to the network utility for retaining the original_dest.
Risk Level:
Medium: Because we have to hardcode this with a define, there is a risk that upstream this gets changed and we would have to adjust. The define is necessary without the unmerged patch from Oct 2016. The TLDR is that the C code does not compile well with our compiler as shown here.
Testing:
Current tests exist
Docs Changes:
In progress
Release Notes:
Support IPv6 for original_dest in network utility
Fixes #1094