Skip to content

util: Add test for checking the format of proto files. #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 2 commits into from
Jul 23, 2018
Merged

util: Add test for checking the format of proto files. #3923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2c6c7
Add test for checking the format of proto files.
jmarantz Jul 22, 2018
1ddfc87
Add files for testing check_format of proto files
jmarantz Jul 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/check_format_test_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ def checkFileExpectingOK(filename):
errors += fixFileExpectingSuccess("header_order.cc")
errors += fixFileExpectingSuccess("license.BUILD")
errors += fixFileExpectingSuccess("bad_envoy_build_sys_ref.BUILD")
errors += fixFileExpectingSuccess("proto_format.proto")
errors += fixFileExpectingFailure("no_namespace_envoy.cc",
"Unable to find Envoy namespace or NOLINT(namespace-envoy)")
errors += fixFileExpectingFailure("mutex.cc",
Expand Down Expand Up @@ -161,6 +162,8 @@ def checkFileExpectingOK(filename):
errors += checkFileExpectingError("license.BUILD", "envoy_build_fixer check failed")
errors += checkFileExpectingError("bad_envoy_build_sys_ref.BUILD",
"Superfluous '@envoy//' prefix")
errors += checkFileExpectingError("proto_format.proto", "clang-format check failed")

errors += checkFileExpectingOK("ok_file.cc")

errors += fixFileExpectingFailure("proto.BUILD",
Expand Down
1 change: 1 addition & 0 deletions tools/testdata/check_format/proto_format.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// This commment is too long for the line-limit built into our clang configuration, so it will need to be wrapped.
2 changes: 2 additions & 0 deletions tools/testdata/check_format/proto_format.proto.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// This commment is too long for the line-limit built into our clang
// configuration, so it will need to be wrapped.