coverage: coverage runs for a single test target.#3922
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jul 23, 2018
Merged
coverage: coverage runs for a single test target.#3922htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Useful when exploring fuzzer code coverage with the checked-in corpus, e.g. envoyproxy#3921. Signed-off-by: Harvey Tuch <htuch@google.com>
alyssawilk
reviewed
Jul 23, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Thank you for the improvements here!
| the `COVERAGE_TARGET` and `VALIDATE_COVERAGE` environment variables, e.g.: | ||
|
|
||
| ``` | ||
| COVERAGE_TARGET=//test/common/common:base64_fuzz_test VALIDATE_COVERAGE=false test/run_envoy_bazel_coverage.sh |
Contributor
There was a problem hiding this comment.
What will happen if we do coverage target for something like foo/bar:all or foo/bar/... ?
I'd assume the tests would run but the copy would still fail. Worth fixing?
Member
Author
There was a problem hiding this comment.
Probably not right now, since the coverage story is going to be replaced soon enough with bazel coverage.
Contributor
There was a problem hiding this comment.
"Soon enough" you say.... so can I quote you on that?
alyssawilk
approved these changes
Jul 23, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM because even if it doesn't fix everything it's a nice incremental improvement. :-)
| the `COVERAGE_TARGET` and `VALIDATE_COVERAGE` environment variables, e.g.: | ||
|
|
||
| ``` | ||
| COVERAGE_TARGET=//test/common/common:base64_fuzz_test VALIDATE_COVERAGE=false test/run_envoy_bazel_coverage.sh |
Contributor
There was a problem hiding this comment.
"Soon enough" you say.... so can I quote you on that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful when exploring fuzzer code coverage with the checked-in corpus, e.g. #3921.
Signed-off-by: Harvey Tuch htuch@google.com