Update gauges when a subset LB is destroyed#3917
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jul 20, 2018
Merged
Update gauges when a subset LB is destroyed#3917mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Without these updates, the gauges will be incorrect after a hot restart. Fixes envoyproxy#3916 Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
|
Please test this in one of the subset LB tests. You should be able to check that the gauge is zero when the test completes. Thank you! |
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
@mattklein123 yup yup, added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these updates, the gauges will be incorrect after a hot
restart.
Fixes #3916
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com