http: ensure the per-stream idle timer is disabled at stream end.#3914
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 20, 2018
Merged
http: ensure the per-stream idle timer is disabled at stream end.#3914mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Previously, this could have left the idle timer active during deferred delete. Thanks to @mattklein123 for spotting this. Risk Level: Low Testing: New unit test. Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Jul 20, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, thanks for the quick turnaround. I will still take a look at the core dump to see if there is something else to look at.
ccaraman
approved these changes
Jul 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this could have left the idle timer active during deferred delete. Thanks to
@mattklein123 for spotting this.
Risk Level: Low
Testing: New unit test.
Signed-off-by: Harvey Tuch htuch@google.com