build: BUILD file changes necessary for #3892#3909
Merged
htuch merged 4 commits intoenvoyproxy:masterfrom Jul 26, 2018
greenhouse-org:windows-ninja-2
Merged
build: BUILD file changes necessary for #3892#3909htuch merged 4 commits intoenvoyproxy:masterfrom greenhouse-org:windows-ninja-2
htuch merged 4 commits intoenvoyproxy:masterfrom
greenhouse-org:windows-ninja-2
Conversation
Splitting this into two PRs to pass CI Signed-off-by: Sam Smith <sesmith177@gmail.com>
sesmith177
changed the title
Signed-off-by: Akshat Gokhale <agokhale@pivotal.io> Signed-off-by: Sam Smith <sesmith177@gmail.com>
This was an artifact from when livevent generated event.lib on Windows and libevent.a + libevent_pthreads.a on Linux. Since Linux now just has libevent.a, this is no longer needed Signed-off-by: Sam Smith <sesmith177@gmail.com> Signed-off-by: Akshat Gokhale <agokhale@pivotal.io>
Picks up the new libevent.a that includes the symbols from the old libevent_pthreads.a Signed-off-by: Akshat Gokhale <agokhale@pivotal.io> Signed-off-by: Sam Smith <sesmith177@gmail.com>
Member
Author
|
@lizan we've bumped the build container image and updated this PR to remove the workarounds |
lizan
approved these changes
Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As requested in #3892, breaking the BUILD file changes out into a separate PR
Risk Level:
Low
Testing:
bazel build //source/exe:envoy-staticandbazel test //test/...on LinuxDocs Changes:
None
Release Notes:
None