tcp/conn_pool: improve interface for callers#3903
Merged
zuercher merged 3 commits intoenvoyproxy:masterfrom Jul 23, 2018
Merged
tcp/conn_pool: improve interface for callers#3903zuercher merged 3 commits intoenvoyproxy:masterfrom
zuercher merged 3 commits intoenvoyproxy:masterfrom
Conversation
Provides additional pool failure reasons to allow Tcp::ConnectionPool callers to distinguish between time outs and connection failures. Passes through connection and buffer watermark events. A subsequent PR will switch the TCP proxy to use the TCP connection pool (and makes use of these features). Relates to envoyproxy#3818. *Risk Level*: low *Testing*: unit tests *Docs Changes*: n/a *Release Notes*: n/a Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
4 tasks
Member
Author
|
@mattklein123 or @alyssawilk do you want to have a look? |
alyssawilk
reviewed
Jul 23, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Looks good to me - only one nit on my end.
include/envoy/tcp/conn_pool.h
Outdated
| ConnectionFailure | ||
| // A local connection failure took place and the connection could not be bound. | ||
| LocalConnectionFailure, | ||
| // A remote connection failure took place and the connection could not be bound. |
Contributor
There was a problem hiding this comment.
when we say bound here, we mean bound to an Envoy client connection rather than a literal bind() call right?
If so could we rephrase to make that more clear?
Member
|
LGTM from quick skim. Happy to defer to @ggreenway and @alyssawilk. Excited to see all this code converge. |
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
…e reasons Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
alyssawilk
approved these changes
Jul 23, 2018
ggreenway
approved these changes
Jul 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides additional pool failure reasons to allow Tcp::ConnectionPool
callers to distinguish between time outs and connection failures.
Passes through connection and buffer watermark events.
A subsequent PR will switch the TCP proxy to use the TCP connection
pool (and makes use of these features). Relates to #3818.
Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher stephan@turbinelabs.io