Skip to content

load_stats: fix for Google import. #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 1 commit into from
Jul 19, 2018
Merged

load_stats: fix for Google import. #3900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions source/common/upstream/load_stats_reporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,11 @@ void LoadStatsReporter::onReceiveMessage(
void LoadStatsReporter::startLoadReportPeriod() {
// Once a cluster is tracked, we don't want to reset its stats between reports
// to avoid racing between request/response.
std::unordered_map<absl::string_view, std::chrono::steady_clock::duration, StringViewHash>
existing_clusters;
// TODO(htuch): They key here could be absl::string_view, but this causes
// problems due to referencing of temporaries in the below loop with Google's
// internal string type. Consider this optimization when the string types
// converge.
std::unordered_map<std::string, std::chrono::steady_clock::duration> existing_clusters;
for (const std::string& cluster_name : message_->clusters()) {
if (clusters_.count(cluster_name) > 0) {
existing_clusters.emplace(cluster_name, clusters_[cluster_name]);
Expand Down