oauth2: fix the code_verifier_cookie config is not set#38963
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Mar 30, 2025
Merged
oauth2: fix the code_verifier_cookie config is not set#38963mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Boteng Yao <boteng@google.com>
mattklein123
approved these changes
Mar 30, 2025
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
) Introduced by envoyproxy#37849 It is clear that `code_verifier_cookie_settings_` is not set to the `FilterConfig`, and only the default is used. Commit Message: Additional Description: Risk Level: low Testing: unit test Docs Changes: Signed-off-by: Boteng Yao <boteng@google.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
) Introduced by envoyproxy#37849 It is clear that `code_verifier_cookie_settings_` is not set to the `FilterConfig`, and only the default is used. Commit Message: Additional Description: Risk Level: low Testing: unit test Docs Changes: Signed-off-by: Boteng Yao <boteng@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by #37849
It is clear that
code_verifier_cookie_settings_is not set to theFilterConfig, and only the default is used.Commit Message:
Additional Description:
Risk Level: low
Testing: unit test
Docs Changes: