health check: allow request header formatting for HTTP health check request#3882
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jul 26, 2018
dio:fix-3835
Merged
health check: allow request header formatting for HTTP health check request#3882mattklein123 merged 3 commits intoenvoyproxy:masterfrom dio:fix-3835
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
dio:fix-3835
Conversation
dio
changed the title
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Contributor
|
Thanks for doing this! I tried this branch out and it definitely fixed my issue (injecting upstream metadata) |
zuercher
reviewed
Jul 23, 2018
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Thanks for this change.
Could you add a link from the HttpHealthCheck request_headers_to_add field to the Http Connection Manager custom request headers section and a note in version_history.rst? (The ref is <config_http_conn_man_headers_custom_request_headers>.)
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Member
Author
|
@bplotnick thank you for verifying this! @zuercher, thanks for the review. Updated the doc and release note in here: 75d1be9. |
Member
Author
|
@zuercher is there anything else that I need to look at? Thanks |
zuercher
approved these changes
Jul 26, 2018
Member
|
@alyssawilk do you have time to take a look? |
mattklein123
approved these changes
Jul 26, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables the use of header formatting pattern for HTTP health check request.
And while at this, the hostname initialization is moved to the
HttpActiveHealthCheckSession's constructor for consistency.Risk Level: Low.
Testing: Unit test.
Docs Changes: Updated.
Release Notes: Added.
Fixes #3835
Signed-off-by: Dhi Aurrahman dio@rockybars.com