Skip to content

http: minor perf improvement for h1 ignored upgrades #38802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KBaichoo merged 1 commit into from
Mar 19, 2025
Merged

http: minor perf improvement for h1 ignored upgrades #38802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/common/http/http1/settings.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Http1Settings parseHttp1Settings(const envoy::config::core::v3::Http1ProtocolOpt

if (!config.ignore_http_11_upgrade().empty()) {
std::vector<Matchers::StringMatcherPtr> matchers;
matchers.reserve(config.ignore_http_11_upgrade_size());
for (const auto& matcher : config.ignore_http_11_upgrade()) {
matchers.emplace_back(std::make_unique<Envoy::Matchers::StringMatcherImpl>(matcher, context));
}
Expand Down
2 changes: 1 addition & 1 deletion source/common/http/utility.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ void Utility::removeUpgrade(RequestOrResponseHeaderMap& headers,
}

void Utility::removeConnectionUpgrade(RequestOrResponseHeaderMap& headers,
StringUtil::CaseUnorderedSet tokens_to_remove) {
const StringUtil::CaseUnorderedSet& tokens_to_remove) {
if (headers.Connection()) {
const std::string new_value =
StringUtil::removeTokens(headers.getConnectionValue(), ",", tokens_to_remove, ",");
Expand Down
2 changes: 1 addition & 1 deletion source/common/http/utility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ void removeUpgrade(RequestOrResponseHeaderMap& headers,
* set of values. Removes the `Connection` header if it only contains `tokens_to_remove`.
*/
void removeConnectionUpgrade(RequestOrResponseHeaderMap& headers,
StringUtil::CaseUnorderedSet tokens_to_remove);
const StringUtil::CaseUnorderedSet& tokens_to_remove);

struct EncodeFunctions {
// Function to modify locally generated response headers.
Expand Down
Loading