Skip to content

cache: redis backend#38550

Closed
cpakulski wants to merge 13 commits intoenvoyproxy:mainfrom
cpakulski:issue/27154
Closed

cache: redis backend#38550
cpakulski wants to merge 13 commits intoenvoyproxy:mainfrom
cpakulski:issue/27154

Conversation

@cpakulski
Copy link
Contributor

Commit Message:

Additional Description:
See https://github.com/cpakulski/envoy/blob/issue/27154/source/extensions/http/cache/redis_http_cache/DESIGN.md for more info.
Risk Level: Low
Testing: TBD
Docs Changes: TBD
Release Notes: TBD
Platform Specific Features:
Fixes #27154

Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38550 was opened by cpakulski.

see: more, trace.

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #38550 was opened by cpakulski.

see: more, trace.

@cpakulski
Copy link
Contributor Author

@ravenblackx and @jmarantz - I am wondering if you could do quick initial code review to check is there is anything obviously wrong in this PR (you commented on linked issue #27154). The code works but lacks coverage and tests. I wanted to get your opinion before committing to writing (not so trivial) tests. Thank you!

@ravenblackx
Copy link
Contributor

I have a giant PR in flight that's going to change the API for this (which should actually make it much simpler for you, but unfortunately too late as you've already done the work, so now it's more work to refit it...)

#37990 in case you want to follow along.

@cpakulski
Copy link
Contributor Author

I have a giant PR in flight that's going to change the API for this (which should actually make it much simpler for you, but unfortunately too late as you've already done the work, so now it's more work to refit it...)

#37990 in case you want to follow along.

Actually timing is not bad. I will check the #37990 and adjust my code to work with new API. The crux of my PR is management of connections to Redis and this is independent from cache filter.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 28, 2025
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Apr 4, 2025
@ravenblackx ravenblackx reopened this Apr 4, 2025
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 5, 2025
@github-actions
Copy link

github-actions bot commented May 5, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 5, 2025
@cpakulski
Copy link
Contributor Author

WIP

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label May 5, 2025
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 4, 2025
@cpakulski
Copy link
Contributor Author

Waiting for refactored filter to be merged.

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 4, 2025
@github-actions
Copy link

github-actions bot commented Jul 5, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 5, 2025
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redis Cache backend

3 participants