Skip to content

common: minor doc updates #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 2 commits into from
Jul 12, 2018
Merged

common: minor doc updates #3845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e2a422
minor doc changes
ramaraochavali Jul 12, 2018
118d113
trigger build again
ramaraochavali Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/common/common/backoff_strategy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ class JitteredBackOffStrategy : public BackOffStrategy {

public:
/**
* Use this constructor if max_interval need to be enforced.
Copy link
Contributor Author

@ramaraochavali ramaraochavali Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htuch sorry. missed this earlier. This comment does not make sense now that we have removed the other constructor that used to allow this object creation without bounds

* Constructs fully jittered backoff strategy.
* @param base_interval the base_interval to be used for next backoff computation.
* @param max_interval if the computed next backoff is more than this, this will be returned.
* @param max_interval the cap on the next backoff value.
* @param random the random generator
*/
JitteredBackOffStrategy(uint64_t base_interval, uint64_t max_interval,
Expand Down