runtime: local ratelimit: remove deprecated timer based token bucket#38197
Merged
wbpcode merged 3 commits intoenvoyproxy:mainfrom Jan 29, 2025
Merged
runtime: local ratelimit: remove deprecated timer based token bucket#38197wbpcode merged 3 commits intoenvoyproxy:mainfrom
wbpcode merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
Member
Author
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
wbpcode
changed the title
mattklein123
previously approved these changes
Jan 27, 2025
Member
Author
|
friendly ping for a new review or approval, thanks cc @mattklein123 |
mattklein123
previously approved these changes
Jan 28, 2025
Member
Author
|
coverage... |
Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
Member
Author
|
/retest |
Member
Author
|
finally... |
Member
Author
|
Hi, @mattklein123 ,may need approval again 🙏🏻🙇♂️ thanks. |
mattklein123
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: local ratelimit: remove deprecated timer based token bucket
Additional Description:
We deprecated the timer based token bucket at #35207 and now six mounths have gone and we removed the guard and the legacy code path.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]