util: ignore unknown fields in parsing jsons#3778
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Jul 3, 2018
Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
mattklein123
reviewed
Jul 3, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
How about a new utility test that would have failed before this change?
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
Thanks, added a regression test. |
htuch
approved these changes
Jul 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Description: Add
ignore_unknown_fieldsoption to parsing JSONs. This is needed since JSON is used to round-trip filter configuration structs, which means new filter config fields will cause older envoys to fail to accept the config.Risk Level: Small. This change makes config parsing more lenient. The risk is in accepting incorrect config, but that is better handled by validation.
Testing: All unit tests pass, added a new regression test.
Docs Changes: None
Release Notes: Allow unknown fields in filter configuration.