lua: add requestInfo():protocol() API#3760
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Jul 3, 2018
dio:lua-request-info-protocol
Merged
lua: add requestInfo():protocol() API#3760mattklein123 merged 7 commits intoenvoyproxy:masterfrom dio:lua-request-info-protocol
mattklein123 merged 7 commits intoenvoyproxy:masterfrom
dio:lua-request-info-protocol
Conversation
This patch adds requestInfo():protocol() to StreamHandleWrapper. This API returns the current HTTP protocol used by the request. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
mattklein123
reviewed
Jul 3, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
nice, LGTM. Small comment nit. Thank you!
|
|
||
| requestInfo = handle:requestInfo() | ||
|
|
||
| Returns some :repo:`information <include/request_info/request_info.h>` related to the current request. |
Member
There was a problem hiding this comment.
nit: remove "some" (we can add more later and people can read below about what is actually available)
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
mattklein123
approved these changes
Jul 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This patch adds
requestInfo():protocol()toStreamHandleWrapper. ThisAPI returns the HTTP protocol version used by current the request.
Risk Level: Low
Testing:
Unit and integration tests
Docs Changes:
requestInfo():protocol()API.Release Notes:
requestInfo()wrapper andprotocol()API.Related issue: #3704
Signed-off-by: Dhi Aurrahman dio@rockybars.com