http conn manager : remove deprecated SAN field#3727
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jun 28, 2018
Merged
http conn manager : remove deprecated SAN field#3727mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Shakti <shaktiprakash.das@salesforce.com>
Signed-off-by: Shakti <shaktiprakash.das@salesforce.com>
mattklein123
approved these changes
Jun 26, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up. @ggreenway @PiotrSikora any concerns?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Remove deprecated SAN field of SetCurrentClientCertDetails from proto and related files.
Risk Level: Low
Testing: Ran all the tests after removing SAN field.
Docs Changes: Docs were already updated. SAN was replaced by URI in the docs when SAN was deprecated.
Release Notes: TODO
*Fixes #3715