bp/1.32: original_ip_detection: revert unintended XFF header appending behavior in CustomHeaderIPDetection #37198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawroh
requested review from
KBaichoo,
RyanTheOptimist,
abeyad,
adisuissa,
alyssawilk,
fredyw,
ggreenway,
jmarantz,
kyessenov,
mattklein123,
nezdolik,
phlax,
ravenblackx,
soulxu,
tyxia,
wbpcode,
yanavlasov and
zuercher
as code owners
agrawroh
force-pushed
the
xff_fix2
branch
2 times, most recently
from
bbeaf86 to
1705a20
Compare
Contributor
|
I think something is wrong with this PR. It contains 290 commits and 1,278 changed files (including lots of merge conflicts). In the current state, I can't review it. |
Member
Author
Sorry, was tracking |
Member
|
@agrawroh this needs to be addressed on |
Member
Author
Member
|
/assign @wbpcode |
wbpcode
changed the title
Member
|
LGTM to the code and backport. But the status of PR is weird. |
Member
|
cc @phlax could you take a look at this when you get some free time? Thanks. |
…r in CustomHeaderIPDetection (envoyproxy#37194) This PR restores the original behavior prior to envoyproxy#31831, by explicitly setting `skip_xff_append` to `true`, as appending the `XFF` header from the custom header extension is not required. See envoyproxy#37171 for more details. --- **Commit Message:** original_ip_detection: revert unintended XFF header appending behavior in CustomHeaderIPDetection **Additional Description:** This PR restores the pre envoyproxy#31831 behavior by explicitly setting `skip_xff_append` to `true`, as appending the `XFF` header from the custom header extension is not required. **Risk Level:** Low **Testing:** Added Unit Tests **Docs Changes:** N/A **Release Notes:** Added Signed-off-by: Rohit Agrawal <[email protected]>
wbpcode
approved these changes
Nov 19, 2024
phlax
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restores the original behavior prior to #31831, by explicitly setting
skip_xff_appendtotrue, as appending theXFFheader from the custom header extension is not required.See #37171 for more details.
Commit Message: original_ip_detection: revert unintended XFF header appending behavior in CustomHeaderIPDetection
Additional Description: This PR restores the pre #31831 behavior by explicitly setting
skip_xff_appendtotrue, as appending theXFFheader from the custom header extension is not required.Risk Level: Low
Testing: Added Unit Tests
Docs Changes: N/A
Release Notes: Added