Fewer external deps #36187
Merged
Fewer external deps #36187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Also remove json.BUILD since it now has native bazel support. Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Also adjust envoy_pch_library to allow for an empty `external_deps`. Signed-off-by: Alejandro R Sedeño <[email protected]>
Many native.bind calls remain here until we update the dependencies to new versions that stop using them. Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R Sedeño <[email protected]>
|
/retest |
asedeno
requested review from
soulxu,
alyssawilk,
mattklein123,
RyanTheOptimist,
abeyad,
fredyw,
zuercher,
wbpcode,
nezdolik,
KBaichoo,
yanavlasov,
tyxia,
ggreenway and
adisuissa
as code owners
phlax
approved these changes
Sep 19, 2024
repokitteh-read-only
bot
removed
the
deps
This was referenced Sep 20, 2024
Merged
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Sep 26, 2024
Commit Message: Remove the native.bind entries for the following libraries: - libcircllhist - uring - ares - xxhash - sqlparser - tclap - fmtlib - spdlog - benchmark - libsxg - yaml_cpp - event - colm - ragel - zlib - brotlienc - brotlidec - zstd - msgpack - opentelemetry_api - dd_trace_cpp - cpp2sky - json - http_parser - hessian2_codec_object_codec_lib - hessian2_codec_codec_impl - su-exec - googletest - protoc - opencensus_trace - opencensus_trace_b3 - opencensus_trace_cloud_trace_context - opencensus_trace_grpc_trace_bin - opencensus_trace_trace_context - opencensus_exporter_ocagent - opencensus_exporter_stdout - opencensus_exporter_stackdriver - opencensus_exporter_zipkin - quiche_common_platform - quiche_http2_adapter - quiche_http2_protocol - quiche_http2_test_tools - quiche_quic_platform - quiche_quic_platform_base - quiche_http2_hpack - quiche_http2_hpack_decoder - jwt_verify_lib - simple_lru_cache_lib - luajit - tcmalloc - tcmalloc_profile_marshaler - tcmalloc_malloc_extension - gperftools - librdkafka Update `external_deps` that used them to `deps` of their actual locations. Some examples: - `zlib` → `//bazel/foreign_cc:zlib` - `json` → `@com_github_nlohmann_json//:json` The bindings that remain are either used by dependencies that need to be updated or have uses in some envoy bazel rules that make removing them trickier. These are the easy ones. Risk Level: low Testing: Building envoy and running integration test suites. Existing tests pass. --------- Signed-off-by: Alejandro R Sedeño <[email protected]> Signed-off-by: Alejandro R. Sedeño <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 21, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Remove the native.bind entries for the following libraries:
Update
external_depsthat used them todepsof their actual locations.Some examples:
zlib→//bazel/foreign_cc:zlibjson→@com_github_nlohmann_json//:jsonThe bindings that remain are either used by dependencies that need to be updated or have uses in some envoy bazel rules that make removing them trickier. These are the easy ones.
Risk Level: low
Testing: Building envoy and running integration test suites. Existing tests pass.