Using drop_overload category in EDS to report drop_overload stats in LRS#36047
Merged
mattklein123 merged 8 commits intoenvoyproxy:mainfrom Sep 19, 2024
Merged
Using drop_overload category in EDS to report drop_overload stats in LRS#36047mattklein123 merged 8 commits intoenvoyproxy:mainfrom
mattklein123 merged 8 commits intoenvoyproxy:mainfrom
Conversation
…LRS. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
changed the title
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/assign @adisuissa @fuqianggao |
|
@fuqianggao cannot be assigned to this issue. |
adisuissa
reviewed
Sep 10, 2024
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
Left some minor comments.
Please add a release note.
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
adisuissa
previously approved these changes
Sep 16, 2024
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Please add a release note as this is a user-facing change.
/assign-from @envoyproxy/senior-maintainers
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM please merge main.
/wait
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/retest |
Contributor
Author
|
Kind Ping |
adisuissa
reviewed
Sep 18, 2024
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
mattklein123
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using drop_overload category in EDS to report drop_overload stats in LRS.
This is a follow up PR to support drop_overload load report service: #31384
Currently it is reporting with a fixed category "drop_overload". This PR changes it into the category passed in by cluster or EDS policy configuration.