quic: add QuicNetworkConnectivityObserver and EnvoyQuicNetworkObserverRegistry interfaces#35912
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
|
/assign @RyanTheOptimist |
danzh2010
changed the title
|
/retest |
Signed-off-by: Dan Zhang <danzh@google.com>
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this.
|
/retest |
It also happen on main, so not related. I will debug into it. |
@danzh2010 I wonder if this relates to #35652 ? Running the test locally with |
No, I'm fixing it in #35960 |
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update .bazelrc to envoyproxy/envoy#35978 - Update ci/run_envoy_docker.sh to envoyproxy/envoy#35926 and envoyproxy/envoy#35660 - Update tools/gen_compilation_database.py to envoyproxy/envoy#36018 and envoyproxy/envoy#35811 - Update source/client/process_impl.cc to match interface change in envoyproxy/envoy#35912 Signed-off-by: Tom Zhang <4367421+tomjzzhang@users.noreply.github.com>
4 participants
Commit Message: Introduce a new classes
QuicNetworkConnectivityObserverandEnvoyQuicNetworkObserverRegistry/EnvoyQuicNetworkObserverRegistryFactoryin Envoy to register each QUIC connection for network changes. AnEnvoyQuicNetworkObserverRegistryFactoryobject can be passed intoClusterManager::createNetworkObserverRegistries()interface to create a thread local EnvoyQuicNetworkObserverRegistry object. Each new Quic connection will register its own QuicNetworkConnectivityObserver to this registry.Additional Description:
QuicNetworkConnectivityObservercurrently has an empty implementation. AndcreateNetworkObserverRegistries()will be called by Envoy Mobile with its own network change aware implementation of the registry factory.Risk Level: low, new interface not in use
Testing: added new unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A