quic: change QuicNetworkConnectivityObserver interface#35775
Merged
CI (Envoy) / Mobile/CC
succeeded
Oct 9, 2025 in 7m 18s
Mobile/CC (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Mobile/CC (pr/35775/main@f22a3d9)
Check started by
Request (pr/35775/main@f22a3d9)
f22a3d9 
#35775 merge main@ed76c2e
quic: change QuicNetworkConnectivityObserver interface
Commit Message: change QuicNetworkConnectivityObserver into pure virtual interface for easy mocking and move the implementation into another class QuicNetworkConnectivityObserverImpl. By doing so, envoy_quic_network_observer_registry_factory_lib no longer needs to depend on QUICHE targets and thus no need to provide a dumb implementation if QUICHE is compiled out.
Also change QuicNetworkConnectivityObserver to have 3 interfaces: onNetworkMadeDefault(), onNetworkConnected() and onNetworkDisconnected().
Risk Level: low, new interface not in use
Testing: n/a
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Runtime guard: N/A
Environment
Request variables
| Key | Value |
|---|---|
| ref | 0a5b533 |
| sha | f22a3d9 |
| pr | 35775 |
| base-sha | ed76c2e |
| actor | @danzh2010 |
| message | quic: change QuicNetworkConnectivityObserver interface... |
| started | 1760041938.566212 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | docker.io/envoyproxy/envoy-build-ubuntu:f4a881a1205e8e6db1a57162faf3df7aed88eae8 |
| mobile | docker.io/envoyproxy/envoy-build-ubuntu:mobile-f4a881a1205e8e6db1a57162faf3df7aed88eae8 |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 36 |
| patch | 0 |
| dev | true |
Loading