Skip to content

1.28 Backport H/2 header discard fix#33300

Closed
SeanKilleen wants to merge 1 commit intoenvoyproxy:release/v1.28from
SeanKilleen:1.28-backport-h2-authority-fix
Closed

1.28 Backport H/2 header discard fix#33300
SeanKilleen wants to merge 1 commit intoenvoyproxy:release/v1.28from
SeanKilleen:1.28-backport-h2-authority-fix

Conversation

@SeanKilleen
Copy link
Copy Markdown

Commit Message:
Discard the Host header if the :authority header was received to bring Envoy into compliance with https://www.rfc-editor.org/rfc/rfc9113#section-8.3.1

This behavioral change can be reverted by setting runtime flag envoy.reloadable_features.http2_discard_host_header to false.

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.http2_discard_host_header
Back-ports #30005, supporting #31118

Discard the Host header if the :authority header was received to bring Envoy into compliance with https://www.rfc-editor.org/rfc/rfc9113#section-8.3.1

This behavioral change can be reverted by setting runtime flag envoy.reloadable_features.http2_discard_host_header to false.

---------

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

Hi @SeanKilleen, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #33300 was opened by SeanKilleen.

see: more, trace.

@SeanKilleen SeanKilleen changed the base branch from main to release/v1.28 April 3, 2024 17:11
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 3, 2024
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @alyssawilk
CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #33300 was opened by SeanKilleen.

see: more, trace.

@SeanKilleen
Copy link
Copy Markdown
Author

I apologize for the continued noise. I am going to close this once more because I believe the DCO issue may have been related to be incorrectly opening this under the wrong base branch.

@SeanKilleen SeanKilleen closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants