1.27 Backport H/2 header discard fix#33297
1.27 Backport H/2 header discard fix#33297SeanKilleen wants to merge 1 commit intoenvoyproxy:release/v1.27from
Conversation
|
Hi @SeanKilleen, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah just the change from the original commit
Discard the Host header if the :authority header was received to bring Envoy into compliance with https://www.rfc-editor.org/rfc/rfc9113#section-8.3.1 This behavioral change can be reverted by setting runtime flag envoy.reloadable_features.http2_discard_host_header to false. --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
SeanKilleen
force-pushed
the
1.27-discard-fix
branch
from
1fcae0c to
6359625
Compare
|
Not sure what happened here; was following pretty explicit steps. I'll get it together and try once more. |
|
ping me on slack if you want - happy to help - would be good to get these backports on the branch ahead of next release |
|
probably the step i missed out was fetching from envoys current branches |
3 participants
Commit Message:
Discard the Host header if the :authority header was received to bring Envoy into compliance with https://www.rfc-editor.org/rfc/rfc9113#section-8.3.1
This behavioral change can be reverted by setting runtime flag envoy.reloadable_features.http2_discard_host_header to false.
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.http2_discard_host_header
Back-ports #30005, supporting #31118