Skip to content

Revert "coverage: lower coverage for source/common/io/ (#32150)"#32845

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:cov-io-uring
Mar 12, 2024
Merged

Revert "coverage: lower coverage for source/common/io/ (#32150)"#32845
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:cov-io-uring

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Mar 12, 2024

This reverts commit 9f92f4c.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

)"

This reverts commit 9f92f4c.

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @alyssawilk

🐱

Caused by: #32845 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Mar 12, 2024

/coverage

@repokitteh-read-only
Copy link
Copy Markdown

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/32845/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

🐱

Caused by: a #32845 (comment) was created by @phlax.

see: more, trace.

Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks for sorting this out!

@phlax phlax merged commit 85b0f29 into envoyproxy:main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants