Skip to content

[bp/1.29] http2: Switch the value of envoy.reloadable_features.http2_use_oghttp…#32766

Merged
phlax merged 1 commit intoenvoyproxy:release/v1.29from
phlax:release-1.29-bp
Mar 7, 2024
Merged

[bp/1.29] http2: Switch the value of envoy.reloadable_features.http2_use_oghttp…#32766
phlax merged 1 commit intoenvoyproxy:release/v1.29from
phlax:release-1.29-bp

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Mar 7, 2024

…2 to false (#32751)

http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including #32611 and #32401 so reverting this flag seems wise.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…2 to false (envoyproxy#32751)

http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false
A number of users have reported issues with oghttp2 including envoyproxy#32611 and envoyproxy#32401
so reverting this flag seems wise.

Signed-off-by: Ryan Hamilton <rch@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #32766 was opened by phlax.

see: more, trace.

@phlax phlax added this to the 1.29.2 milestone Mar 7, 2024
@phlax phlax enabled auto-merge (rebase) March 7, 2024 11:58
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax merged commit 57a0256 into envoyproxy:release/v1.29 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants