Skip to content

Revert H/2 codec back to nghttp2#32741

Closed
yanavlasov wants to merge 1 commit intoenvoyproxy:mainfrom
yanavlasov:oghttp2-off
Closed

Revert H/2 codec back to nghttp2#32741
yanavlasov wants to merge 1 commit intoenvoyproxy:mainfrom
yanavlasov:oghttp2-off

Conversation

@yanavlasov
Copy link
Copy Markdown
Contributor

@yanavlasov yanavlasov commented Mar 6, 2024

Risk Level: Low (unlikely that someone depends on oghttp2 specific behavior, since the change was very recent).
Testing: Unit Tests
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Fixes #32611 #32371

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #32741 was opened by yanavlasov.

see: more, trace.

Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a race with #32751, but otherwise LGTM :)

@KBaichoo
Copy link
Copy Markdown
Contributor

KBaichoo commented Mar 7, 2024

#32751 merged, closing this

@KBaichoo KBaichoo closed this Mar 7, 2024
@yanavlasov yanavlasov deleted the oghttp2-off branch March 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to oghttp2=true causes cookie-related failures

3 participants