google_grpc: add a runtime flag to disable TLSv1.3#32690
Closed
briansonnenberg wants to merge 2 commits intoenvoyproxy:release/v1.25from
Closed
google_grpc: add a runtime flag to disable TLSv1.3#32690briansonnenberg wants to merge 2 commits intoenvoyproxy:release/v1.25from
briansonnenberg wants to merge 2 commits intoenvoyproxy:release/v1.25from
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: publish-envoy[bot] <140627008+publish-envoy[bot]@users.noreply.github.com>
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315) Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4 Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added. Additional Description: Risk Level: low, default false Testing: regression Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d Signed-off-by: Kuat Yessenov <kuat@google.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/runtime-guard-changes: FYI only for changes made to |
Contributor
|
Looks like DCO needs to be fixed. In any case, 1.25 hit end of life as of January, according to https://github.com/envoyproxy/envoy/blob/main/RELEASES.md Why are we back porting to and end-of-life version? /wait |
Contributor
|
This should be sent to a fork, sorry :) 1.25 is used in production, but we don't expect Envoy to cut another 1.25 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32235 and #32315