Skip to content

Logging: ENVOY_BUG include filter name. #32663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KBaichoo merged 1 commit into from
Mar 4, 2024
Merged

Logging: ENVOY_BUG include filter name. #32663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/common/http/filter_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,9 @@ void FilterManager::decodeHeaders(ActiveStreamDecoderFilter* filter, RequestHead

const auto continue_iteration = (*entry)->commonHandleAfterHeadersCallback(status, end_stream);
ENVOY_BUG(!continue_iteration || !state_.local_complete_,
"Filter did not return StopAll or StopIteration after sending a local reply.");
fmt::format(
"filter={} did not return StopAll or StopIteration after sending a local reply.",
(*entry)->filter_context_.config_name));

// If this filter ended the stream, decodeComplete() should be called for it.
if ((*entry)->end_stream_) {
Expand Down