Skip to content

sockets: flipping graceful client socket creation failure #32602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanTheOptimist merged 2 commits into from
Mar 1, 2024
Merged

sockets: flipping graceful client socket creation failure #32602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ebbf7a
sockets: flipping graceful client socket creation failure
alyssawilk Feb 27, 2024
4ba5a72
comments
alyssawilk Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ behavior_changes:

minor_behavior_changes:
# *Changes that may cause incompatibilities for some users, but should not for most*
- area: sockets
change: |
Failure to create an upstream socket should now result in clean connection failure rather than failing a release assert. This behavior
can be temporarily reverted by setting runtime feature ``envoy.restart_features_.allow_client_socket_creation_failure`` to false.
- area: adaptive concurrency filter stats
change: |
Multiply the gradient value stat by 1000 to make it more granular (values will range between 500 and 2000).
Expand Down
2 changes: 1 addition & 1 deletion source/common/network/listen_socket_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void ListenSocketImpl::setupSocket(const Network::Socket::OptionsSharedPtr& opti

UdsListenSocket::UdsListenSocket(const Address::InstanceConstSharedPtr& address)
: ListenSocketImpl(ioHandleForAddr(Socket::Type::Stream, address, {}), address) {
RELEASE_ASSERT(io_handle_->isOpen(), "");
RELEASE_ASSERT(io_handle_ && io_handle_->isOpen(), "");
Copy link
Copy Markdown
Contributor

@RyanTheOptimist RyanTheOptimist Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the release notes, the impression I have is that this release assert change would be guarded y the runtime feature. But that's not the case here. Presumably that's ok, because this is just downstream of the actual important code which guarded by the feature. is that right?

bind(connection_info_provider_->localAddress());
}

Expand Down
2 changes: 1 addition & 1 deletion source/common/network/listen_socket_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ template <typename T> class NetworkListenSocket : public ListenSocketImpl {
address) {
// Prebind is applied if the socket is bind to port.
if (bind_to_port) {
RELEASE_ASSERT(io_handle_->isOpen(), "");
RELEASE_ASSERT(io_handle_ && io_handle_->isOpen(), "");
setPrebindSocketOptions();
setupSocket(options);
} else {
Expand Down
3 changes: 1 addition & 2 deletions source/common/runtime/runtime_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,12 @@ RUNTIME_GUARD(envoy_reloadable_features_use_http3_header_normalisation);
RUNTIME_GUARD(envoy_reloadable_features_validate_connect);
RUNTIME_GUARD(envoy_reloadable_features_validate_grpc_header_before_log_grpc_status);
RUNTIME_GUARD(envoy_reloadable_features_validate_upstream_headers);
RUNTIME_GUARD(envoy_restart_features_allow_client_socket_creation_failure);
RUNTIME_GUARD(envoy_restart_features_send_goaway_for_premature_rst_streams);
RUNTIME_GUARD(envoy_restart_features_udp_read_normalize_addresses);

// Begin false flags. Most of them should come with a TODO to flip true.

// TODO(alyssawilk) flip true after server side is handled.
FALSE_RUNTIME_GUARD(envoy_restart_features_allow_client_socket_creation_failure);
// Execution context is optional and must be enabled explicitly.
// See https://github.com/envoyproxy/envoy/issues/32012.
FALSE_RUNTIME_GUARD(envoy_restart_features_enable_execution_context);
Expand Down